Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data getter functionality #189

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Improve data getter functionality #189

merged 2 commits into from
Sep 12, 2024

Conversation

tasansal
Copy link
Contributor

tl;dr

  • Return traces/headers etc., in user-requested order.
  • Allow ndarray indexing
  • Consolidate int, ndarray, and list indexing to a single function

If users asked for traces in descending or random order, the read optimizations returned traces/headers in an unexpectedly sorted order. We now return in the same order the user asked for.

@tasansal tasansal added the enhancement New feature or request label Sep 12, 2024
@tasansal tasansal self-assigned this Sep 12, 2024
@tasansal tasansal changed the title Improve data getting functionality Improve data getter functionality Sep 12, 2024
@tasansal tasansal merged commit acd94db into main Sep 12, 2024
30 checks passed
@tasansal tasansal deleted the preserve-data-order branch September 12, 2024 21:51
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (5753b40) to head (53b79e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   94.98%   95.18%   +0.19%     
==========================================
  Files          47       47              
  Lines        2135     2140       +5     
  Branches      253      251       -2     
==========================================
+ Hits         2028     2037       +9     
+ Misses         81       79       -2     
+ Partials       26       24       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant