Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rememberPlayer(THEOplayerView) #40

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

MattiasBuelens
Copy link
Collaborator

Currently, the UI always creates its own THEOplayerView:

  • If you call DefaultUI with a config parameter, then it creates a THEOplayerView and Player itself.
  • If you call DefaultUI with a player parameter, you still have to create that Player using rememberPlayer(), which always creates a THEOplayerView itself.

This adds a new overload rememberPlayer(THEOplayerView), which wraps an existing THEOplayerView in a Player rather than creating a new one. This makes it easier to add integrations upfront, or to remove the UI without removing the player.

@MattiasBuelens MattiasBuelens added the enhancement New feature or request label Sep 10, 2024
@MattiasBuelens MattiasBuelens merged commit 89ab444 into develop Sep 10, 2024
1 check passed
@MattiasBuelens MattiasBuelens deleted the wrap-existing-theoplayerview branch September 10, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant