Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VENTUS][fix] Fix memory flags set in tablegen #129 #130

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

zhoujingya
Copy link
Collaborator

In previous logic ,default memory access flag is 0b00, this will cause all no-local/no-private related instructions return true when fall into RISCVInstrInfo::isUniformMemoryAccess logic

In previous logic ,default memory access flag is 0b00, this will cause
all no-local/no-private related instructions return true when fall into
`RISCVInstrInfo::isUniformMemoryAccess` logic
@zhoujingya zhoujingya linked an issue Jun 24, 2024 that may be closed by this pull request
Copy link
Collaborator

@ziliangzl ziliangzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujingya zhoujingya merged commit ddc7052 into main Jun 25, 2024
2 checks passed
@zhoujingya zhoujingya deleted the memory branch June 25, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

执行build-ventus.sh出错
2 participants