Structure, clippy and doc strings #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Begin visibility work Clippy integration Clippy fixes update dependencies
Several clippy fixes also applied
doc/crate Add crate level doc
|
Thanks @dirvine. For the initial configuration of the network, I think we should, instead, start exporting it in some kind of format file (this is a must). I prefer XML or JSON for this kind of serialization. I was looking for standards but without success. Then we can use this format as import or initial configuration. For NEAT configuration I think toml will be great. What do you think? |
|
Yes I agree, if there was a standard configuration format, perhaps on the gym you posted then it makes a lot of sense. The prob with JSON perhaps is comments are lost but lets investigate. Importing the genes and genomes from a file though is for sure something we should do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry again for a much too large PR. This restructures the lib as per issue #14
Start on visibility rules as per issue #9
A gitter board will help a lot as I am not 100% sure of the weight / innovation parameters. I hope now to be able to start really looking into the lib with reference to the stanly paper and c++ reference implementation. May be good to add ability to read config (toml?) for setting up initial genes and connections etc.
Please feel free to comment and critique as widely as you wish, I realise these PR's are way too large.