Merge pull request #313 from TNG/chore/compiler-warnings

Resolve Compiler Warnings
TNG · Oct 11, 2024 · 717deb0 · 717deb0
2 parents 60bf37c + 3adb40d
commit 717deb0
Show file tree

Hide file tree

Showing 26 changed files with 80 additions and 62 deletions.
diff --git a/ArchUnitNET.MSTestV2/ArchUnitNET.MSTestV2.csproj b/ArchUnitNET.MSTestV2/ArchUnitNET.MSTestV2.csproj
@@ -16,6 +16,7 @@
         <IncludeSymbols>true</IncludeSymbols>
         <SymbolPackageFormat>snupkg</SymbolPackageFormat>
         <PackageReadmeFile>README.md</PackageReadmeFile>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/ArchUnitNET.MSTestV2Tests/ArchUnitNET.MSTestV2Tests.csproj b/ArchUnitNET.MSTestV2Tests/ArchUnitNET.MSTestV2Tests.csproj
@@ -2,10 +2,9 @@
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
-
     <IsPackable>false</IsPackable>
-
     <Company>TNG Technology Consulting GmbH</Company>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/ArchUnitNET.NUnit/ArchUnitNET.NUnit.csproj b/ArchUnitNET.NUnit/ArchUnitNET.NUnit.csproj
@@ -16,6 +16,7 @@
         <IncludeSymbols>true</IncludeSymbols>
         <SymbolPackageFormat>snupkg</SymbolPackageFormat>
         <PackageReadmeFile>README.md</PackageReadmeFile>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/ArchUnitNET.NUnitTests/ArchUnitNET.NUnitTests.csproj b/ArchUnitNET.NUnitTests/ArchUnitNET.NUnitTests.csproj
@@ -2,10 +2,9 @@
 
     <PropertyGroup>
         <TargetFramework>net8.0</TargetFramework>
-
         <IsPackable>false</IsPackable>
-
         <Company>TNG Technology Consulting GmbH</Company>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/ArchUnitNET.xUnit/ArchUnitNET.xUnit.csproj b/ArchUnitNET.xUnit/ArchUnitNET.xUnit.csproj
@@ -16,6 +16,7 @@
         <IncludeSymbols>true</IncludeSymbols>
         <SymbolPackageFormat>snupkg</SymbolPackageFormat>
         <PackageReadmeFile>README.md</PackageReadmeFile>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/ArchUnitNET/ArchUnitNET.csproj b/ArchUnitNET/ArchUnitNET.csproj
@@ -16,6 +16,7 @@
         <IncludeSymbols>true</IncludeSymbols>
         <SymbolPackageFormat>snupkg</SymbolPackageFormat>
         <PackageReadmeFile>README.md</PackageReadmeFile>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/ArchUnitNET/Fluent/Syntax/Elements/Members/MemberConditionsDefinition.cs b/ArchUnitNET/Fluent/Syntax/Elements/Members/MemberConditionsDefinition.cs
@@ -176,7 +176,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -422,7 +422,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }

diff --git a/ArchUnitNET/Fluent/Syntax/Elements/Members/MemberPredicatesDefinition.cs b/ArchUnitNET/Fluent/Syntax/Elements/Members/MemberPredicatesDefinition.cs
@@ -139,7 +139,7 @@ IEnumerable<T> Condition(IEnumerable<T> members, Architecture architecture)
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -318,7 +318,7 @@ IEnumerable<T> Condition(IEnumerable<T> members, Architecture architecture)
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }

diff --git a/ArchUnitNET/Fluent/Syntax/Elements/Members/MethodMembers/MethodMemberConditionsDefinition.cs b/ArchUnitNET/Fluent/Syntax/Elements/Members/MethodMembers/MethodMemberConditionsDefinition.cs
@@ -222,7 +222,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -494,7 +494,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -936,7 +936,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -1228,7 +1228,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }

diff --git a/ArchUnitNET/Fluent/Syntax/Elements/Members/MethodMembers/MethodMemberPredicatesDefinition.cs b/ArchUnitNET/Fluent/Syntax/Elements/Members/MethodMembers/MethodMemberPredicatesDefinition.cs
@@ -160,7 +160,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -338,7 +338,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -625,7 +625,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -808,7 +808,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }

diff --git a/ArchUnitNET/Fluent/Syntax/Elements/ObjectConditionsDefinition.cs b/ArchUnitNET/Fluent/Syntax/Elements/ObjectConditionsDefinition.cs
@@ -542,7 +542,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -820,7 +820,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -1308,7 +1308,7 @@ Architecture architecture
                         var archUnitAttribute = architecture.GetAttributeOfType(type);
                         archUnitAttributeList.Add(archUnitAttribute);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -1730,7 +1730,7 @@ bool Condition(TRuleType obj, Architecture architecture)
                 {
                     archUnitAttribute = architecture.GetAttributeOfType(attribute);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     return false;
@@ -2099,7 +2099,7 @@ bool Condition(TRuleType obj, Architecture architecture)
                 {
                     archUnitAttribute = architecture.GetAttributeOfType(attribute);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     return false;
@@ -2851,7 +2851,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -3103,7 +3103,7 @@ Architecture architecture
                         var archUnitAttribute = architecture.GetAttributeOfType(type);
                         archUnitAttributeList.Add(archUnitAttribute);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -3527,7 +3527,7 @@ bool Condition(TRuleType obj, Architecture architecture)
                 {
                     archUnitAttribute = architecture.GetAttributeOfType(attribute);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     return true;
@@ -3898,7 +3898,7 @@ bool Condition(TRuleType obj, Architecture architecture)
                 {
                     archUnitAttribute = architecture.GetAttributeOfType(attribute);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     return true;

diff --git a/ArchUnitNET/Fluent/Syntax/Elements/ObjectPredicatesDefinition.cs b/ArchUnitNET/Fluent/Syntax/Elements/ObjectPredicatesDefinition.cs
@@ -335,7 +335,7 @@ IEnumerable<T> Filter(IEnumerable<T> objects, Architecture architecture)
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -500,7 +500,7 @@ IEnumerable<T> Filter(IEnumerable<T> objects, Architecture architecture)
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -808,7 +808,7 @@ IEnumerable<T> Filter(IEnumerable<T> objects, Architecture architecture)
                         var archUnitAttribute = architecture.GetAttributeOfType(type);
                         archUnitAttributeList.Add(archUnitAttribute);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -1148,7 +1148,7 @@ bool Predicate(T obj, Architecture architecture)
                 {
                     archUnitAttribute = architecture.GetAttributeOfType(attribute);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     return false;
@@ -1449,7 +1449,7 @@ bool Predicate(T obj, Architecture architecture)
                 {
                     archUnitAttribute = architecture.GetAttributeOfType(attribute);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     return false;
@@ -1915,7 +1915,7 @@ IEnumerable<T> Filter(IEnumerable<T> objects, Architecture architecture)
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -2078,7 +2078,7 @@ IEnumerable<T> Filter(IEnumerable<T> objects, Architecture architecture)
                         var archUnitAttribute = architecture.GetAttributeOfType(type);
                         archUnitAttributeList.Add(archUnitAttribute);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -2418,7 +2418,7 @@ bool Predicate(T obj, Architecture architecture)
                 {
                     archUnitAttribute = architecture.GetAttributeOfType(attribute);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     return true;
@@ -2721,7 +2721,7 @@ bool Predicate(T obj, Architecture architecture)
                 {
                     archUnitAttribute = architecture.GetAttributeOfType(attribute);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     return true;

diff --git a/ArchUnitNET/Fluent/Syntax/Elements/Types/TypeConditionsDefinition.cs b/ArchUnitNET/Fluent/Syntax/Elements/Types/TypeConditionsDefinition.cs
@@ -44,7 +44,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't be equal anyways
                     }
@@ -285,7 +285,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -578,7 +578,7 @@ Architecture architecture
                 {
                     archUnitInterface = architecture.GetInterfaceOfType(intf);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     interfaceNotInArchitecture = true;
@@ -850,7 +850,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't be equal anyways
                     }
@@ -1114,7 +1114,7 @@ Architecture architecture
                         var archUnitType = architecture.GetITypeOfType(type);
                         archUnitTypeList.Add(archUnitType);
                     }
-                    catch (TypeDoesNotExistInArchitecture e)
+                    catch (TypeDoesNotExistInArchitecture)
                     {
                         //ignore, can't have a dependency anyways
                     }
@@ -1258,7 +1258,7 @@ Architecture architecture
                 {
                     archUnitInterface = architecture.GetInterfaceOfType(intf);
                 }
-                catch (TypeDoesNotExistInArchitecture e)
+                catch (TypeDoesNotExistInArchitecture)
                 {
                     //can't have a dependency
                     interfaceNotInArchitecture = true;