-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve test coverage and add snapshot tests for object conditions #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderlinne
force-pushed
the
ci/object-condition-tests
branch
from
August 24, 2024 18:53
642ba85
to
3b7b095
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 56.70% 65.37% +8.66%
==========================================
Files 254 254
Lines 22842 22842
Branches 1938 1938
==========================================
+ Hits 12953 14932 +1979
+ Misses 9334 7368 -1966
+ Partials 555 542 -13 ☔ View full report in Codecov by Sentry. |
alexanderlinne
force-pushed
the
ci/object-condition-tests
branch
from
August 26, 2024 19:37
3b7b095
to
897a3c7
Compare
Signed-off-by: Alexander Linne <[email protected]>
alexanderlinne
force-pushed
the
ci/object-condition-tests
branch
from
August 26, 2024 19:41
897a3c7
to
8520889
Compare
Signed-off-by: Alexander Linne <[email protected]>
alexanderlinne
force-pushed
the
ci/object-condition-tests
branch
from
August 28, 2024 18:35
dca773e
to
53af522
Compare
mak638
reviewed
Aug 30, 2024
mak638
reviewed
Aug 31, 2024
mak638
reviewed
Aug 31, 2024
mak638
previously approved these changes
Aug 31, 2024
Signed-off-by: Alexander Linne <[email protected]>
alexanderlinne
force-pushed
the
ci/object-condition-tests
branch
from
September 3, 2024 13:48
3d223e7
to
57be322
Compare
Signed-off-by: Alexander Linne <[email protected]>
alexanderlinne
force-pushed
the
ci/object-condition-tests
branch
from
September 3, 2024 13:59
65a4cd7
to
a428ef6
Compare
mak638
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add new test cases for methods defined in
ArchUnitNET/Fluent/Syntax/Elements/ObjectsShould.cs
andArchUnitNET/Fluent/Syntax/Elements/ObjectConditionsDefinition.cs
that achieves the following:ArchUnitNETTests
assembly as the architecture for our tests. Instead, we add separate assemblies that contain a small number of types. This reduces the number of hits per line from hundreds or thousands to usually less than ten.The new tests will replace tests in
ArchUnitNETTests/Fluent/Syntax/Elements/ObjectSyntaxElementsTests.cs
, but to remove these tests without reducing the code coverage, additional tests forArchUnitNET/Fluent/Syntax/Elements/ObjectPredicatesDefinition.cs
will be needed.Relates to #229, providing a way to check for changes to the error messages in pull requests