Loader: Match Types By Assembly Qualified Name #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Linne <[email protected]>
alexanderlinne
force-pushed
the
292-missing-classes-in-architecture
branch
from
a7e3237
to
af2ba60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 65.37% 65.41% +0.04%
==========================================
Files 254 254
Lines 22842 22853 +11
Branches 1938 1938
==========================================
+ Hits 14932 14949 +17
+ Misses 7368 7360 -8
- Partials 542 544 +2 ☔ View full report in Codecov by Sentry. |
fgather
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292, adding the ability to
ArchBuilderandTypeRegistryto differentiate between types with the same full name but from different assemblies.