fix: prevent script from exiting when file already exist

[PaulFarault]

Which issue(s) this PR fixes

Fixes None

Additional comments

wget used with both --no-clober and --output-document options exit with a non-zero status when the file already exist.
This cause the script to stop because of set -e. Hence, the script won't download the remaining files.

Agreements

• I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
• I hereby agree to grant TOSIT a copyright license to use my contributions.

[kpgtek]

I think the alternative solution that you mentionned in the description is more suitable (than the use of || true).

[PaulFarault]

@kpgtek I agree with you, I switch the PR to this version.

[kpgtek]

I think we need to keep and use file_name variable, in order to rename and to put the version in the file name, so the modification could be:

download_tdp_binaries() {
  while IFS=";" read -r uri_file_name file_name
  do
    if [[ -n "$file_name" ]]
    then
      local target_file=${file_name}
    else
      local target_file=${file_name:-$(basename ${uri_file_name})}
    fi
    wget --continue --output-document="files/${target_file}" ${uri_file_name}
  done < scripts/tdp-release-uris.txt
}

[PaulFarault]

Thanks for your feedback @kpgtek!