Fix bugs in assignment operators #71

Thoemi09 · 2024-06-23T10:16:20Z

There were 2 bugs:

Assigning a 1D contiguous range to a view did not work, since the assignment operator tried to construct a non-const view of a const range (it takes the range as const &).
A bug in the function call operator in _impl_basic_array_view_common.hpp allowed to assign to const views/arrays, since it returned a view with non-const value type.

Wentzell

Thank you @Thoemi09 for locating and fixing these issues!

Thoemi09 force-pushed the DEV_ASSIGNMENT_BUGS branch from 020a791 to ab88b86 Compare July 4, 2024 09:40

Thoemi09 force-pushed the DEV_ASSIGNMENT_BUGS branch from ab88b86 to 9a12eb8 Compare July 18, 2024 14:03

Wentzell force-pushed the unstable branch 8 times, most recently from 2cdbb07 to eac10ed Compare July 30, 2024 16:18

Thoemi09 and others added 6 commits July 30, 2024 13:51

Fix bug in assignment of a contiguous range to a view

3f5eb68

Disallow assignment to const arrays/views

97b210a

Add test for ambiguous assignment operator issue

2681a52

Fix ambiguous assignment operator issue

4bb88f4

Restore move-only type in nda_array_adapter test

43fc60a

Simplify syntax in nda/h5.hpp

552473d

Wentzell force-pushed the DEV_ASSIGNMENT_BUGS branch from 9a12eb8 to 552473d Compare July 30, 2024 20:54

Wentzell approved these changes Jul 30, 2024

View reviewed changes

Wentzell merged commit 6b45cc5 into TRIQS:unstable Jul 30, 2024
4 of 5 checks passed

Thoemi09 deleted the DEV_ASSIGNMENT_BUGS branch August 9, 2024 19:02

Provide feedback