Button Fixes and TargetID Integration #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGoll
added
type/bug
Histalek
approved these changes
Aug 17, 2024
Co-authored-by: Histalek <[email protected]>
Co-authored-by: Histalek <[email protected]>
Merged
TimGoll
added a commit
that referenced
this pull request
Sep 14, 2024
This pullrequest introduces a further fix to buttons that were introduced by the move of use calls to the client. It fixes the same issue the last PR (#1580) attempted to fix, but this time it improves upon this. Two things are done in this PR: - added `foundButton:SetSolid(SOLID_BSP)` to make sure all buttons on the map can be actually hit by a trace. This also fixes the issue introduced in the last PR, where some buttons now had a hitbox the player could collide with - rewrote the syncing to the client as it was a nightmare. Many entites are NULL entities on the client if the player is too far away. This new approach with NWInts fixes this because it makes use of the internal GMod systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1557
Adds TargetID to leavers ...
... and buttons
Note: The fix of this issue was done by making the lever and buttons non-solid. This has to be done both on server and client. After that was done, the addition of targetID consists only of 20 lines of code.
Note 2: The button and lever entities are non-detectable on the client as they are only a base entity there. Therefore it has to be synced from the server.