MapVote: Readded compatibility with old mapvote addons #1592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most mapvote addons work by overwriting the
LoadNextMap()
function. However in a recent rework, the TTT2 gameloop got completely reworked which broke that way of hooking into it.The easiest solution here is to add a fallback mode that calls the overwritten function if defined. This is done here. Additionally I raise an error to make sure the server owner is aware of the problem.
When this function is called, the next map condition is already met. And since these functions are all based on the old TTT function, the condition will still be met inside it, even if the round counter is decreased by one more. Therefore we don't have to modify any values here.
By doing it that way it is pretty clean and safe to call deprecated map vote trigger functions, without hacking too much into the TTT2 gameloop.