Merge pull request #209 from TU-Wien-dataLAB/208-race-condition-when-…

…spawning-git-processes-for-autograding

Fix Subprocess race condition

grader_service/autograding/local_grader.py

@@ -14,7 +14,7 @@
 from dataclasses import dataclass
 from datetime import datetime
 from pathlib import Path
-from subprocess import PIPE, CalledProcessError
+from subprocess import Popen, PIPE, CalledProcessError
 from typing import Optional
 
 from traitlets.config import Config
@@ -26,7 +26,6 @@
 from grader_service.orm.lecture import Lecture
 from grader_service.orm.submission import Submission
 from sqlalchemy.orm import Session
-from tornado.process import Subprocess
 from traitlets.config.configurable import LoggingConfigurable
 
 from traitlets.traitlets import TraitError, Unicode, validate, Callable
@@ -426,7 +425,7 @@ def _cleanup(self):
         if self.close_session:
             self.session.close()
 
-    async def _run_subprocess(self, command: str, cwd: str) -> Subprocess:
+    async def _run_subprocess(self, command: str, cwd: str) -> Popen[bytes]:
         """
         Execute the command as a subprocess.
         :param command: The command to execute as a string.
@@ -435,9 +434,8 @@ async def _run_subprocess(self, command: str, cwd: str) -> Subprocess:
         which resulted from the execution.
         """
         try:
-            process = Subprocess(shlex.split(command),
-                                 stdout=PIPE, stderr=PIPE, cwd=cwd)
-            await process.wait_for_exit()
+            process = Popen(shlex.split(command), stdout=PIPE, stderr=PIPE, cwd=cwd)
+            process.wait()
         except CalledProcessError:
             self.grading_logs = process.stderr.read().decode("utf-8")
             self.log.error(self.grading_logs)