Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): allow selecting model in answer engine #3304

Merged
merged 30 commits into from
Nov 5, 2024
Merged

feat(ui): allow selecting model in answer engine #3304

merged 30 commits into from
Nov 5, 2024

Conversation

antimonyGu
Copy link
Contributor

@antimonyGu antimonyGu commented Oct 23, 2024 •
edited
Loading

front end of #3097

  • When supported_model is not set,
    no-supported-model

  • When supported_model set,
    recording

@antimonyGu antimonyGu marked this pull request as draft October 23, 2024 05:29
@antimonyGu antimonyGu changed the title llm select FE sketch feat(chat-ui): llm select FE sketch Oct 23, 2024
@antimonyGu antimonyGu marked this pull request as ready for review October 28, 2024 20:35
@antimonyGu antimonyGu changed the title feat(chat-ui): llm select FE sketch feat(chat-ui): llm select FE Oct 28, 2024
wsxiaoys
wsxiaoys requested changes Oct 30, 2024
View reviewed changes
ee/tabby-schema/src/schema/thread/inputs.rs Outdated Show resolved Hide resolved
ee/tabby-webserver/src/service/answer.rs Outdated Show resolved Hide resolved
@antimonyGu antimonyGu changed the title feat(chat-ui): llm select FE feat(chat-ui): chatl lm select Oct 30, 2024
@antimonyGu antimonyGu changed the title feat(chat-ui): chatl lm select feat(chat-ui): chat lm select Oct 30, 2024
@wsxiaoys wsxiaoys changed the title feat(chat-ui): chat lm select feat(ui): support selecting model in answer engine Oct 30, 2024
@wsxiaoys wsxiaoys changed the title feat(ui): support selecting model in answer engine feat(ui): allow selecting model in answer engine Oct 31, 2024
@antimonyGu antimonyGu force-pushed the llm-select branch 3 times, most recently from 8904586 to 0653df9 Compare November 1, 2024 06:48
liangfung
liangfung reviewed Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@liangfung liangfung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The function onRegenerateResponse requires the modelName parameter to be passed in.
  2. Consider disabling sendUserMessage until the /v1beta/models endpoint has successfully returned, and determine the display of TextareaSearch.

ee/tabby-ui/components/textarea-search.tsx Outdated Show resolved Hide resolved
ee/tabby-ui/components/textarea-search.tsx Outdated Show resolved Hide resolved
@wsxiaoys wsxiaoys merged commit 28a5328 into TabbyML:main Nov 5, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangfung liangfung liangfung left review comments

@wsxiaoys wsxiaoys wsxiaoys requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antimonyGu @wsxiaoys @liangfung