Updated OpenFaceConfig.cmake #730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you make the PR against the develop branch? I'm planning on integrating changes from develop to master soon. It changed the CMake files a reasonable amount. |
TadasBaltrusaitis
requested changes
Jul 8, 2019
|
Could you make this PR into develop rather than master branch? The develop has changed quite a bit compared to master in terms of CMake, this will also ensure that the CI tests are passing (the CI checks on master are now a bit out of date) |
marynelv
commented
Jul 9, 2019
|
The Continuous Integration checks are failing. Have you merged the newest master of OpenFace into your master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble using the config for cmake because the set_and_check function was checking if a given file existed, but it was called with a list of files. Updated the config file so that it only checks for the OpenFace headers. Also updated the versions of the dependencies. They didn't seem to match the installation instructions for Ubuntu.