-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sending evm tx with Acala #1090
Conversation
ummmm it seems there are some compatibility issue, let me take a look into this, will update the PR soon |
@alecdwm previous issue was that jest didn't seem to respect Now running |
Thanks for the PR! And for the jest fix 🎉 We're just about to release v1.19.0 after some extended testing, so it's unlikely this will make it into that release. But I've heard the plan is to include this PR in a hotfix once we're done with that Edit: You can ignore that |
sounds awesome! Thanks a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR - thought it was good to go however I will have to change my review after further testing
When testing, I found that this PR doesn't work with Talisman's send funds UI when sending Acala substrate assets. The user can't progress to the 'Review' stage, probably because some awaited request has not resolved. The current dev branch is able to send Acala assets in the same way. I wasn't able to dig into the reason. Could you please look into this?
@chidg thanks for your review, I tried sending ACA on the substrate side with locally built talisman on this branch, and it worked for me. I was not blocked on the review page, and the tx actually went through. Were you sending any other assets? Could this happened to be your network issue? |
hey @chidg, any updates on this? Please let me know if there is anything else I can help |
Thanks @shunjizhan , I have been AFK for the past couple of weeks. Will have another look this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks for the neat PR @shunjizhan and apologies for the delay in approving.
LGTM!
Thanks @chidg! Please keep me updated once this is included in the release |
Change
Currently when sending acala evm tx, talisman will throw tx hash mismatch error.
This commit switches to
AcalaJsonRpcProvider
for Acala network family, which solves the above issueTest
tx hash mismatch
anymore