Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more reliable autolock alarms #1738

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: more reliable autolock alarms #1738

wants to merge 1 commit into from

Conversation

alecdwm
Copy link
Member

@alecdwm alecdwm commented Dec 11, 2024

Current behaviour:

  • run autolock on initial delay of x, if missed for any reason then retry every x interval

New behaviour:

  • run autolock on initial delay of x, if missed for any reason then retry every 30s

@alecdwm alecdwm enabled auto-merge (squash) December 11, 2024 03:56
chidg
chidg reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerned this could become a footgun in future, let's leave this one until we establish the real cause of reported problems

@alecdwm alecdwm disabled auto-merge December 11, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg chidg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecdwm @chidg