chore: avoid notification flood

TallerWebSolutions · Nov 13, 2024 · bc2ff67 · bc2ff67
1 parent bba062a
commit bc2ff67
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/app/adapters/jira/jira_issue_adapter.rb b/app/adapters/jira/jira_issue_adapter.rb
@@ -243,9 +243,9 @@ def read_assigned_responsibles(demand, history_date, responsible_name)
         item_assignment.update(finish_time: nil)
       else
         item_assignment = demand.item_assignments.create(membership: membership, start_time: history_date)
-        demand_url = company_demand_url(demand.company, demand)
+        company_demand_url(demand.company, demand)
 
-        Slack::SlackNotificationService.instance.notify_item_assigned(item_assignment, demand_url)
+        # Slack::SlackNotificationService.instance.notify_item_assigned(item_assignment, demand_url)
       end
 
       item_assignment.id

diff --git a/app/jobs/slack/demand_slack_notifications_job.rb b/app/jobs/slack/demand_slack_notifications_job.rb
@@ -28,7 +28,7 @@ def process_assignments(demand)
 
       demand.item_assignments.reload.where(assignment_notified: false).each do |assignment|
         demand_url = company_demand_url(demand.company, demand)
-        # Slack::SlackNotificationService.instance.notify_item_assigned(assignment, demand_url)
+        Slack::SlackNotificationService.instance.notify_item_assigned(assignment, demand_url)
         ItemAssignment.transaction { assignment.update(assignment_notified: true) }
       end
     end

diff --git a/spec/jobs/slack/demand_slack_notifications_job_spec.rb b/spec/jobs/slack/demand_slack_notifications_job_spec.rb
@@ -68,15 +68,15 @@
       end
     end
 
-    # context 'with assignments' do
-    #   it 'calls the notification method for the assignments not notified yet' do
-    #     Fabricate :item_assignment, demand: demand, assignment_notified: false
-    #     Fabricate :item_assignment, demand: demand, assignment_notified: false
-    #     Fabricate :item_assignment, demand: demand, assignment_notified: true
-    #
-    #     # expect_any_instance_of(Slack::SlackNotificationService).to receive(:notify_item_assigned).twice
-    #     described_class.perform_now(team)
-    #   end
-    # end
+    context 'with assignments' do
+      it 'calls the notification method for the assignments not notified yet' do
+        Fabricate :item_assignment, demand: demand, assignment_notified: false
+        Fabricate :item_assignment, demand: demand, assignment_notified: false
+        Fabricate :item_assignment, demand: demand, assignment_notified: true
+
+        expect_any_instance_of(Slack::SlackNotificationService).to receive(:notify_item_assigned).twice
+        described_class.perform_now(team)
+      end
+    end
   end
 end