Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start): returning null from server functions #3048

Merged
merged 18 commits into from
Dec 22, 2024

Conversation

alakhpc
Copy link
Contributor

@alakhpc alakhpc commented Dec 20, 2024

Fixes #2776, pass through null returns from serverfns

@schiller-manuel
Copy link
Contributor

can you please cherry-pick this on top? #2778

@alakhpc

This comment was marked as outdated.

Copy link

nx-cloud bot commented Dec 21, 2024

View your CI Pipeline Execution ↗ for commit 9f7645d.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 4m 38s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 43s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-22 19:13:02 UTC

Copy link

pkg-pr-new bot commented Dec 21, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3048

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3048

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3048

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3048

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3048

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3048

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3048

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3048

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3048

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3048

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3048

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3048

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3048

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3048

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@3048

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3048

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3048

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3048

commit: 9f7645d

@SeanCassiere SeanCassiere changed the title Fix returning null from serverfns fix(start): returning null from server functions Dec 22, 2024
@SeanCassiere SeanCassiere merged commit 4a7d3ca into TanStack:main Dec 22, 2024
5 checks passed
@SeanCassiere
Copy link
Member

@alakhpc thank you for contributing this fix 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start: createServerFn cannot return null
4 participants