Experiment with using findReferencedIdentifiers to avoid extra aggressive DCE #3149
+127
−270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is pretty messy currently, but the idea based on pcattori/babel-dead-code-elimination#34 (comment) is to find some way of getting the referenced identifiers before Start does any transformations, so it can use them when doing dead code elimination. this would mean that the only dead code that gets eliminated is any that wasn't there before Start.
I also have no idea how to test that a server side effect happened in Playwright, so that'll be a fun hurdle to cross.
from research i have basically found two "accepted" ways of communicating between plugins:
options
in one plugin and getting them out in the otherThis PR currently uses the first, because buildStart seems to be receiving an empty object in my tests.