-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derived Stores #40
Open
crutchcorn
wants to merge
107
commits into
main
Choose a base branch
from
derived-diamond-problem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Derived Stores #40
+2,327
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crutchcorn
force-pushed
the
derived-diamond-problem
branch
from
February 7, 2024 09:42
c0c0d1c
to
790303c
Compare
Woo! 🏎️ |
Angular is the fastest, nice 😄! |
View your CI Pipeline Execution ↗ for commit 1aab40c.
☁️ Nx Cloud last updated this comment at |
Out of curiosity, what's the state of this PR and what's stopping it from being reviewed/merged? |
+1 |
# Conflicts: # .eslintrc.cjs # knip.json # package.json # packages/solid-store/package.json # packages/store/package.json # packages/store/src/index.ts # packages/store/src/tests/index.test.tsx # packages/store/tests/derived.bench.ts # packages/store/tests/derived.test.ts # packages/store/tests/effect.test.ts # packages/store/tests/index.test.tsx # packages/store/tests/store.test.ts # packages/vue-store/package.json # pnpm-lock.yaml
…/store into derived-diamond-problem
…/store into derived-diamond-problem
…/store into derived-diamond-problem
…/store into derived-diamond-problem
# Conflicts: # docs/framework/angular/reference/functions/injectstore.md # docs/framework/react/reference/functions/usestore.md # docs/framework/solid/reference/functions/usestore.md # docs/framework/svelte/reference/functions/usestore.md # docs/framework/vue/reference/functions/usestore.md # docs/reference/classes/store.md # docs/reference/interfaces/storeoptions.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an initial
Derived
class implementation:Note
This API of
mount
seems wonky for application use because, well, it is. It's intended for other libraries like TanStack Form and TanStack Table's internals.We may introduce a more application-friendly
Derived
andEffect
API for usage in apps, but it's not clear yet what that looks like. Please feel free to jump into the discussion here for moreTODO
Derived State
that includesprevVal
andprevVals
Derived
to make sure it continues to workDerived
/Effect
's side effects to explicitmount
andunmount
methodspreviousValues
toDerived
Edgecase Handling
This Derived implementation even solves the diamond problem:
Where writes to "a" will call "d" twice (with a flicker of incorrect data known as a "Glitch") because of the dual-derived nature. Our implementation does not have this problem and therefore can be considered "glitch-free"
This is a push-based/hot signals implementation
Benchmarks
Due to the relatively naive nature of this code (I wrote it in one night at ~midnight) there are performance implication in using this. Namely, in our benchmarks we are a far cry from Angular or Solid's implementation, but come close to Vue's implementation: