Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done in this PR
Note
This file largely referenced existing benchmarks in arrow-parquet. Two major sources are
arrow/cpp/src/parquet/encoding_benchmarks.cc
andarrow/cpp/src/parquet/column_io_benchmarks.cc
.The reasons I write a new file instead of using the original benchmarks are:
Warning
thirdparty/arrow/cpp/src/parquet/
. Also,thirdparty/arrow/cpp/src/parquet/CMakeLists.txt
needs to add this benchmark file by adding the following command at line 433.build_third_party.sh
disabled the parquet benchmark generation. On my local machine, I successfully build the benchmarks by executing the following code inarrow/cpp/build
.In docker environment, I tried to use same command to build benchmarks using
ninja parquet-benchmarks
but the process will fail in linking stage.Relating Issues:
#6
#7