-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/138 fcm #170
Open
leeyoonchae
wants to merge
6
commits into
develop
Choose a base branch
from
feature/138-fcm
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/138 fcm #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhello0507
reviewed
Sep 30, 2024
Projects/App/Project.swift
Outdated
@@ -39,7 +39,9 @@ let project = Project( | |||
.project(target: "Feature", path: .relativeToRoot("Projects/Feature")), | |||
.project(target: "Repository", path: .relativeToRoot("Projects/Data")), | |||
.project(target: "DIContainer", path: .relativeToRoot("Projects/DIContainer")), | |||
.target(name: "DodamDodamWidget") | |||
.target(name: "DodamDodamWidget"), | |||
.external(name: "FirebaseAnalytics"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FirebaseAnalytics도 필요한가요?
Tuist/Package.swift
Outdated
@@ -30,6 +30,7 @@ let package = Package( | |||
.package(url: "https://github.com/Mercen-Lee/FlowKit", branch: "main"), | |||
.package(url: "https://github.com/Mercen-Lee/SignKit", exact: "0.0.2"), | |||
.package(url: "https://github.com/lorenzofiamingo/swiftui-cached-async-image", exact: "2.1.1"), | |||
.package(url: "https://github.com/bestswlkh0310/SwiftBok", exact: "1.2.0") | |||
.package(url: "https://github.com/bestswlkh0310/SwiftBok", exact: "1.2.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SwiftBok 이제 안 쓰니 삭제 해주세요
삭제하기 전에 브런치 만들어서 아직 남아있나 보네요
leeyoonchae
force-pushed
the
feature/138-fcm
branch
from
September 30, 2024 06:10
94dec33
to
1f2e27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.