Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changable Audio Device, bugfixes #2

Merged
merged 7 commits into from
Oct 5, 2024
Merged

Add changable Audio Device, bugfixes #2

merged 7 commits into from
Oct 5, 2024

Conversation

heyngra
Copy link
Contributor

@heyngra heyngra commented Sep 29, 2024 •
edited
Loading

Currently implemented:

  • Get rid of Bar going out of bounds
  • Add settings tab
  • Add changable Audio Device

CaptSiro
CaptSiro reviewed Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@CaptSiro CaptSiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think creating a new variable clampFill is necessary. Can you please change it to just using clamp function?

@heyngra
remove clamp function, add settings + audio device
bb72060 
no idea if save works, but audio device changing does
@heyngra heyngra changed the title Improvements, bugfixes Add changable Audio Device, bugfixes Sep 29, 2024
CaptSiro
CaptSiro reviewed Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@CaptSiro CaptSiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see proper checking. Better be sure than sorry. Later I will try to fix the settings part

src/renderer/src/components/settings/SettingDropdown.tsx Outdated Show resolved Hide resolved
src/renderer/src/components/settings/SettingsView.tsx Outdated Show resolved Hide resolved
src/renderer/src/lib/Music.ts Outdated Show resolved Hide resolved
@heyngra heyngra requested a review from CaptSiro October 2, 2024 22:22
CaptSiro
CaptSiro previously approved these changes Oct 4, 2024
View reviewed changes
@heyngra heyngra marked this pull request as ready for review October 4, 2024 22:39
@heyngra heyngra requested a review from CaptSiro October 4, 2024 22:51
@heyngra heyngra requested a review from CaptSiro October 5, 2024 10:54
CaptSiro
CaptSiro previously approved these changes Oct 5, 2024
View reviewed changes
@heyngra heyngra requested a review from CaptSiro October 5, 2024 20:34
@heyngra heyngra merged commit 864fb1e into Team-BTMC:master Oct 5, 2024
1 check passed
@CaptSiro
Copy link
Collaborator

CaptSiro commented Oct 5, 2024

Thanks for contributing :btmcLuv:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duduBTW duduBTW duduBTW left review comments

@CaptSiro CaptSiro CaptSiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyngra @CaptSiro @duduBTW