Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use osu!.db instead of iterating through songs folder #21

Merged
merged 23 commits into from
Oct 7, 2024
Merged

Conversation

hrfarmer
Copy link
Collaborator

@hrfarmer hrfarmer commented Oct 3, 2024

Supercedes #5

Todo

  • Add background source
  • Change frontend wording to tell you to select installation folder instead of songs folder

@hrfarmer hrfarmer requested a review from CaptSiro as a code owner October 3, 2024 19:33
@hrfarmer hrfarmer marked this pull request as draft October 3, 2024 19:34
@hrfarmer hrfarmer marked this pull request as ready for review October 5, 2024 05:26
src/@types.d.ts Show resolved Hide resolved
src/@types.d.ts Show resolved Hide resolved
src/main/lib/osu-file-parser/OsuParser.ts Show resolved Hide resolved
src/main/lib/osu-file-parser/OsuParser.ts Outdated Show resolved Hide resolved
src/main/lib/osu-file-parser/OsuParser.ts Outdated Show resolved Hide resolved
src/main/lib/osu-file-parser/OsuParser.ts Outdated Show resolved Hide resolved
src/main/lib/osu-file-parser/OsuParser.ts Outdated Show resolved Hide resolved
src/main/lib/osu-file-parser/OsuParser.ts Outdated Show resolved Hide resolved
src/main/lib/osu-file-parser/OsuParser.ts Outdated Show resolved Hide resolved
src/main/lib/osu-file-parser/OsuParser.ts Outdated Show resolved Hide resolved
@CaptSiro
Copy link
Collaborator

CaptSiro commented Oct 5, 2024

Please change all snake_case to camelCase and move and wrap Buffer methods to a separate class

@kiwec kiwec mentioned this pull request Oct 5, 2024
@hrfarmer
Copy link
Collaborator Author

hrfarmer commented Oct 6, 2024

nevermind the ci fix broke the intersection observer,

@CaptSiro just going to ask you what to do about this, because it works fine right now but ci yells, but i dont know how to fix ci without breaking the intersection observer because i don't know how it works

Copy link
Contributor

@heyngra heyngra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BPM is completly out of the roof
this pr:
image

master from 2 days ago:
image

@brw
Copy link
Member

brw commented Oct 7, 2024

@CaptSiro just going to ask you what to do about this, because it works fine right now but ci yells, but i dont know how to fix ci without breaking the intersection observer because i don't know how it works

fixed above. I think it had something to do with which tsconfig was being used based on the import path, and only the web one contains "jsxImportSource": "solid-js".
like I said on Discord you shouldn't have to move children to a prop. It's an inherent prop containing the child JSX elements.

@hrfarmer hrfarmer requested a review from CaptSiro October 7, 2024 04:27
@hrfarmer hrfarmer merged commit f8e8581 into master Oct 7, 2024
1 check passed
@CaptSiro
Copy link
Collaborator

CaptSiro commented Oct 7, 2024

Thank you for contributing :btmcLuv:

@hrfarmer hrfarmer deleted the db branch October 7, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants