-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: organize imports and types with import aliases #96
base: master
Are you sure you want to change the base?
Conversation
Not sure if I really like it the way I have it now but just see what you think of my changes @Tnixc. I'm very much open to suggestions. I'm not quite sure how to organize this stuff tbh. I had to move the search-parser and template-parser types to I went through a lot of the tsconfig documentation, looked at many templates and examples, had many back-and-forths with ChatGPT and tried a bunch of different setups but I still don't feel like I know what the right approach here would be honestly lol. Changing the .d.ts files to .ts did also uncover a few bugs/type errors as .d.ts files weren't actually being checked because Couple of notes:
|
|
I don't think you can use JSX in the backend Electron process no and even if you could I don't think you'd want to do that. Better to just define a mapping of possible icons and specify the icon name when creating a notice.
That's the thing, you can't. Not with our split tsconfig setup anyway. You can't import types from files not covered by the tsconfig. You can if you add a reference to the node tsconfig in the web tsconfig but then you essentially have web depend on node as a project, which means it needs to be built first to get the types from it. Probably not great either. I'm also not sure what the best practice here is other than just moving it to a shared package. |
No description provided.