[Feat/#227] Edit Profile & Participant Profile 관련 수정 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Mar 8, 2024
Comment on lines
+19
to
+21
| private val _userState = MutableSharedFlow<Boolean>() | ||
| val userState: SharedFlow<Boolean> | ||
| get() = _userState |
Comment on lines
12
to
+13
| 0 -> ParticipantProfileCharacterFragment() | ||
| else -> ParticipantProfileTagFragment() | ||
| else -> TripProfileTagFragment() |
There was a problem hiding this comment.
요거 제가 네이밍 통일성 주는 게 좋을 것 같아서 다시 ParticipantProfileTagFragment로 고쳤는데
이건 머지되면 제가 다시 고쳐서 pr올리겠슴당
There was a problem hiding this comment.
헉 제가 머지하는 과정에서 컨플릭트 나서 수정하다가 실수한거 같네욤....
패키징도 조금 꼬인거같아서 한번만...정리 부탁드리겠습니다..!!
crownjoe
approved these changes
Mar 8, 2024
Comment on lines
+24
to
+26
| val isChangedSuccess: SharedFlow<Boolean> | ||
| get() = _isChangedSuccess | ||
|
|
| @@ -3,6 +3,7 @@ package com.going.presentation.profile.participant | |||
| import android.content.Context | |||
| import android.content.Intent | |||
| import android.os.Bundle | |||
| import android.util.Log | |||
There was a problem hiding this comment.
엇 요 로그는 안 쓰이는 것 같은데 지워주시면 감사하겠숩니답!!!
There was a problem hiding this comment.
어머나 왜 안지웠지!
후다닥 지우겠습니다 허허
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
awesome.mp4
📢 To Reviewers