[FEAT/#249] 여행 친구 조회 뷰 / 엠티 뷰 구현 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crownjoe
approved these changes
Mar 13, 2024
Comment on lines
+52
to
+59
| private fun initLinkInviteBtnListener() { | ||
| binding.tvTodoInviteTermsText.setOnSingleClickListener { | ||
| val clipboardManager = | ||
| requireContext().getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager | ||
| val clipData = ClipData.newPlainText(CLIP_LABEL, viewModel.inviteCode) | ||
| clipboardManager.setPrimaryClip(clipData) | ||
| if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.S_V2) toast(getString(R.string.finish_trip_tv_copy_code_complete)) | ||
| } |
chattymin
approved these changes
Mar 13, 2024
| @@ -203,17 +231,22 @@ class CheckFriendsActivity : | |||
| override fun onDestroy() { | |||
| super.onDestroy() | |||
| _adapter = null | |||
| if (friendInviteDialog?.isAdded == true) friendInviteDialog?.dismiss() | |||
There was a problem hiding this comment.
?? == ture 라면 뒷부분은 날려도 될듯~~
Suggested change
| if (friendInviteDialog?.isAdded == true) friendInviteDialog?.dismiss() | |
| if (friendInviteDialog?.isAdded) friendInviteDialog?.dismiss() |
There was a problem hiding this comment.
현재 FriendInviteEmptyDialog가 nullable인데 == true를 제거하면 if문은 Boolean 타입인데 Boolean? 타입이 들어가서 타입 불일치가 일어나는 것 같습니다,,!
…into feat/#249-check-friends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240313_034207_doorip.mp4
📢 To Reviewers