[FIX/#263] 유빈 담당 뷰 / 2차 QA 이슈 대응 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/#263-qa-issue
chattymin
approved these changes
Mar 21, 2024
Comment on lines
+42
to
+46
| ProfilePreferenceData("01", "계획은 어느 정도로 세울까요?", "즉흥으로", "철저하게", styleA), | ||
| ProfilePreferenceData("02", "장소 선택의 기준은 무엇인가요?", "로컬장소", "관광지", styleB), | ||
| ProfilePreferenceData("03", "어느 식당을 갈까요?", "가까운 곳", "유명 맛집", styleC), | ||
| ProfilePreferenceData("04", "기억하고 싶은 순간에!", "눈에 담기", "사진 필수", styleD), | ||
| ProfilePreferenceData("05", "하루 일정을 어떻게 채우나요?", "여유롭게", "알차게", styleE) |
There was a problem hiding this comment.
갑자기 든생각인데 이런 공통되는 데이터는� 로컬 DB를 만들고, 기존에 쓰는 방식처럼 Service, Repository 등등 거쳐서 가져오면 유지보수 짱짱될것 같네요!!
추후 이 텍스트를 서버에서 주게 된다면 경로만 수정해주면 되니까 더 간편해지구용!
crownjoe
approved these changes
Mar 22, 2024
Comment on lines
-122
to
+126
| ProfilePreferenceData("01", "계획은 어느 정도로 세울까요?", "철저하게", "즉흥으로", styleA), | ||
| ProfilePreferenceData("02", "장소 선택의 기준은 무엇인가요?", "관광지", "로컬장소", styleB), | ||
| ProfilePreferenceData("03", "어느 식당을 갈까요?", "유명 맛집", "가까운 곳", styleC), | ||
| ProfilePreferenceData("04", "기억하고 싶은 순간에!", "사진필수", "눈에 담기", styleD), | ||
| ProfilePreferenceData("05", "하루 일정을 어떻게 채우나요?", "알차게", "여유롭게", styleE) | ||
| ProfilePreferenceData("01", "계획은 어느 정도로 세울까요?", "즉흥으로", "철저하게", styleA), | ||
| ProfilePreferenceData("02", "장소 선택의 기준은 무엇인가요?", "로컬장소", "관광지", styleB), | ||
| ProfilePreferenceData("03", "어느 식당을 갈까요?", "가까운 곳", "유명 맛집", styleC), | ||
| ProfilePreferenceData("04", "기억하고 싶은 순간에!", "눈에 담기", "사진 필수", styleD), | ||
| ProfilePreferenceData("05", "하루 일정을 어떻게 채우나요?", "여유롭게", "알차게", styleE) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
📢 To Reviewers