feat - 챌린지 달성현황뷰 response에 챌린지 시작날짜 추가 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumining
added
👩🏻💻 주민
jumining
changed the base branch from
develop
to
feat/#134-search-challenge-using-user-table
kseysh
approved these changes
May 17, 2024
Comment on lines
86
to
87
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd"); | ||
| String formattedStartDate = challenge.getCreatedAt().format(formatter); |
There was a problem hiding this comment.
기본적으로 LocalDate는 yyyy-mm-dd로 반환하는 것으로 아는데 혹시 아닌가요??
만약 그렇다면, challenge.getCreatedAt().toLocalDate()로 반환해도 좋을 것 같아요!
There was a problem hiding this comment.
challenge.getCreatedAt().toLocalDate().toString()하면 yyyy-MM-dd형식이더라구요! 좋은 의견 감사합니다!
jumining
changed the base branch from
feat/#134-search-challenge-using-user-table
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
PR 참고 사항