Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix - #188 기존 챌린지 id 값 불러오는 메소드 순서 수정 #189

Merged
merged 6 commits into from
Aug 19, 2024
Merged

fix - #188 기존 챌린지 id 값 불러오는 메소드 순서 수정 #189

merged 6 commits into from
Aug 19, 2024

Conversation

jumining
Copy link
Collaborator

@jumining jumining commented Aug 17, 2024 •
edited
Loading

Related issue 🚀

Work Description 💚

  • 챌린지 생성 로직 내에서 챌린지값 id 수정하는 메소드와 기존 앱 목록 불러오는 메소드의 순서를 변경하였습니다.
  • 챌린지 정보 전송 시 지난 날의 정보만 전송할 수 있도록 인덱스 유효성 검사를 추가하였습니다. (todayIndex<->periodIndex)

PR 참고 사항

  • 테스트코드의 중요성을 또 느꼈습니다 ++1

@jumining jumining added 👩🏻‍💻 주민 주민이가 작성한 Label 🐞 BugFix 에러 수정, 버그 수정 labels Aug 17, 2024
@jumining jumining requested a review from kseysh August 17, 2024 22:06
@jumining jumining self-assigned this Aug 17, 2024
@jumining jumining merged commit 6409927 into develop Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kseysh kseysh Awaiting requested review from kseysh

Assignees

@jumining jumining

Labels
🐞 BugFix 에러 수정, 버그 수정 👩🏻‍💻 주민 주민이가 작성한 Label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix - 챌린지 생성 시 앱 목록 정상적으로 불러오기
1 participant
@jumining