[refac] optimize query execution by reducing select queries

Team-Hankki · Jan 6, 2025 · 51ebbb4 · 51ebbb4
1 parent d21b4a3
commit 51ebbb4
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/org/hankki/hankkiserver/api/menu/service/MenuCommandService.java b/src/main/java/org/hankki/hankkiserver/api/menu/service/MenuCommandService.java
@@ -49,8 +49,9 @@ public void modifyMenu(final MenuPatchCommand command) {
     @Transactional
     public MenusPostResponse createMenus(final MenusPostCommand command) {
         Store findStore = storeFinder.findByIdWhereDeletedIsFalse(command.storeId());
+        List<Menu> allMenus = menuFinder.findAllByStore(findStore);
         List<Menu> menus = command.menu().stream()
-                .filter(c -> !validateMenuConflict(findStore, c.name()))
+                .filter(c -> !validateMenuConflict(allMenus, c.name()))
                 .map(c -> Menu.create(findStore, c.name(), c.price()))
                 .toList();
         menuUpdater.saveAll(menus);
@@ -69,8 +70,8 @@ private void updateLowestPriceInStore(final Store findStore) {
         findStore.updateLowestPrice(menuFinder.findLowestPriceByStore(findStore));
     }
 
-    private boolean validateMenuConflict(final Store store, final String menuName) {
-        return menuFinder.existsByStoreAndName(store, menuName);
+    private boolean validateMenuConflict(final List<Menu> menus, final String menuName) {
+        return menus.stream().anyMatch(menu -> menu.getName().equals(menuName));
     }
 
     private void checkNoMenuInStore(final Store store, final long userId) {