[fix] 식당에 메뉴 1개 남았을 때 메뉴 삭제 시, 식당 삭제 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,11 +51,21 @@ public MenusPostResponse createMenus(final MenusPostCommand command) { | |||
| return MenusPostResponse.of(menus); | |||
| } | |||
|
|
|||
| private void deleteStore(final long id) { | |||
There was a problem hiding this comment.
emptyMenuInStore 함수의 매개변수는 Long인데 혹시 둘이 다르게하신 이유가 있을까요? 아니면 통일하는게 좋을 것 같습니당
There was a problem hiding this comment.
이미 함수명이 deleteStore이라서 굳이 storeId라고 중복명시하는 것 보다는 id라고 명시하는 것이 깔끔하다고 생각했습니당
There was a problem hiding this comment.
아 자료형을 말한 것이었습니다 통일성을 위해 Long/long 중에 하나로 하는게 좋지 않을까해서요
There was a problem hiding this comment.
아 저때는 검증을 마치고 난 후라 wrapper 타입 보다는 원시타입인 long으로 처리하는 것이 낫다고 생각했어요! 둘 다 원시 타입으로 통일하겠습니당
| @Valid @RequestBody final MenuPostRequest request) { | ||
| menuCommandService.modifyMenu(MenuPatchCommand.of(storeId, id, request.name(), request.price())); | ||
| return HankkiResponse.success(CommonSuccessCode.OK); | ||
| } | ||
|
|
||
| @PostMapping("{storeId}/menus/bulk") | ||
| public HankkiResponse<MenusPostResponse> createMenu(@PathVariable final Long storeId, @Valid @RequestBody final List<MenuPostRequest> request) { | ||
| public HankkiResponse<MenusPostResponse> createMenu(@PathVariable @Min(value = 1L) final long storeId, |
There was a problem hiding this comment.
메뉴 여러개 만드는 거라 복수인 Menus로 네이밍해도 될 것 같아융
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #215
Description ✔️
To Reviewers
api 테스트 완료