[feat] 족보 생성 삭제 API #23

PicturePark1101 · 2024-07-08T08:56:07Z

Related Issue 📌

close #16

Description ✔️

족보 생성 API
족보 삭제 API
로그인이랑 연결 완료 (@userid 필요한 create에 선언)

To Reviewers

족보 생성 응답값

{
    "code": 201,
    "message": "리소스가 생성되었습니다."
}

족보 생성 쿼리

    insert 
    into
        favorite
        (created_at, detail, name, updated_at, user_id) 
    values
        (?, ?, ?, ?, ?)

(에러) 족보 title 길이 20 이상 or 빈 문자열

{
    "code": 500,
    "message": "서버 내부 오류가 발생했습니다."
}

족보 삭제 쿼리실행 Test

@Transactional
  public void deleteFavorites(final FavoritesDeleteCommand command) {

    List<Favorite> favorites = favoriteFinder.findByIds(command.favoriteIds());

    Long userId = command.userId();
    favorites.forEach(favorite -> {
      if (!favorite.getUser().getId().equals(userId)) {
        throw new UnauthorizedException(UserErrorCode.USER_FORBIDDEN);
      }
    });

    favoriteStoreDeleter.deleteAllByFavorites(favorites);
    favoriteDeleter.deleteAll(favorites);
  }

UnauthorizedException검사를 위해 select 절 발생

Hibernate: 
    select
        f1_0.favorite_id,
        f1_0.created_at,
        f1_0.detail,
        f1_0.name,
        f1_0.updated_at,
        u1_0.user_id,
        u1_0.created_at,
        u1_0.deleted_at,
        u1_0.email,
        u1_0.member_status,
        u1_0.name,
        u1_0.platform,
        u1_0.serial_id,
        u1_0.updated_at,
        u1_0.user_role 
    from
        favorite f1_0 
    join
        users u1_0 
            on u1_0.user_id=f1_0.user_id 
    where
        f1_0.favorite_id in (?, ?)
Hibernate: 
    delete 
    from
        favorite_store fs1_0 
    where
        fs1_0.favorite_id in (?, ?)
Hibernate: 
    delete 
    from
        favorite f1_0 
    where
        f1_0.favorite_id in (?, ?)

나중에 반영해야할 수도 있는 반영사항.

지금 요청으로 받은 id를 in절로 select하는데 DB에 없을 경우 예외처리 불가
나중에 favorites 의 size와 command.favoriteIds() size를 비교해서 일치하지 않으면 예외 발생하게 해야할지 고민

kgy1008

수고하셨습니당

kgy1008 · 2024-07-08T09:12:38Z

src/main/java/org/hankki/hankkiserver/api/favorite/controller/request/FavoritePostRequest.java

+import java.util.List;
+
+public record FavoritePostRequest(
+    @NotEmpty(message = "제목이 비었습니다.")


@notempty 보다는 @notblank 어노테이션이 더 적절한 것 같습니다. 아래 내용을 참고해주세요.
https://wildeveloperetrain.tistory.com/68

반영했습니다 👍

kgy1008 · 2024-07-08T09:14:32Z

src/main/java/org/hankki/hankkiserver/api/favorite/service/FavoriteAdpater.java

+
+  private final FavoriteRepository favoriteRepository;
+
+  public Favorite findById(final long id) {


변수명을 단순히 id라 하는 것보다는 어떤 객체의 id인지 표현해주는 것이 좋을 것 같은데(ex) userId) 어떻게 생각하시나요?

kgy1008 · 2024-07-08T09:15:48Z

src/main/java/org/hankki/hankkiserver/api/favorite/service/FavoriteCommandService.java

+  @Transactional
+  public Long create(final FavoritePostCommand favoritePostCommand) {
+
+    long userId = favoritePostCommand.memberId();


memberId말고 테이블 명 그대로 userId로 수정하는 것이 좋을 것 같습니다.

놓쳤습니다ㅜㅜ 반영했습니다!

kgy1008 · 2024-07-08T09:38:13Z

src/main/java/org/hankki/hankkiserver/domain/favorite/model/Favorite.java

+            .build();
+    }
+
+    @Builder


클래스 레벨에 @builder 작성해주면 해당 내용 없이도 builder 사용하실 수 있어요!

저는 개인적으로 사용하는 필드들만 갖는 생성자 만든 후에 그 위에 @builder 붙이는 거 선호합니다.

kgy1008 · 2024-07-08T16:01:54Z

src/main/java/org/hankki/hankkiserver/api/favorite/controller/FavoriteController.java

+
+@RestController
+@RequiredArgsConstructor
+@RequestMapping("/api/v1/favorites")


@RequestMapping에는 /api/v1만 남겨주세요!

Parkjyun

고생하셨습니다

Parkjyun · 2024-07-11T05:48:11Z

src/main/java/org/hankki/hankkiserver/api/favorite/controller/FavoriteController.java

+    return HankkiResponse.success(CommonSuccessCode.CREATED);
+  }
+
+  @PostMapping("/favorites/delete")


다중 삭제 기능이란 것을 명확하게 나타내기 위해 /favorites/batch-delete 라고 하는 것은 어떨까요?

반영하겠습니다 👍

Parkjyun · 2024-07-11T05:52:53Z

src/main/java/org/hankki/hankkiserver/api/favorite/service/command/FavoritePostCommand.java

+    List<String> details
+) {
+
+  public static FavoritePostCommand of(final Long memberId, final FavoritePostRequest favoritePostRequest) {


memberId -> userId로 수정해주세요

Parkjyun · 2024-07-11T05:54:35Z

src/main/java/org/hankki/hankkiserver/api/favorite/service/FavoriteCommandService.java

+@RequiredArgsConstructor
+public class FavoriteCommandService {
+
+  private final FavoriteRepository favoriteRepository;


favoriteRespository.save를 favoriteUpdater 안으로 넣어주세요

Parkjyun · 2024-07-11T05:58:23Z

src/main/java/org/hankki/hankkiserver/api/favorite/controller/FavoriteController.java

+  @PostMapping("/favorites")
+  public HankkiResponse<Void> createFavorite(@UserId final Long userId, @RequestBody @Valid final FavoritePostRequest request) {
+
+    favoriteCommandService.create(FavoritePostCommand.of(userId, request));


원래는 201을 내려주면 Location 헤더에 resource의 위치를 포함시켜야 해서
저희 응답을 처리하는 advice에 추후 201상태 코드 가진 친구들에게 location header를 추가해주는 코드를 추가할 예정입니당.
이를 대비해서 create이후에 생성된 리소스의 pk 사용하지 않더라도 일단 갖고 있을 수 있을까요?

Service return 타입을 Long으로 변경하고
return favoriteRepository.save(Favorite.create(findUser, title, details)).getId();
으로 변경하겠습니다.

Parkjyun · 2024-07-11T06:03:16Z

src/main/java/org/hankki/hankkiserver/domain/favorite/model/Favorite.java

+            .build();
+    }
+
+    @Builder


저는 개인적으로 사용하는 필드들만 갖는 생성자 만든 후에 그 위에 @builder 붙이는 거 선호합니다.

Parkjyun · 2024-07-11T07:34:04Z

src/main/java/org/hankki/hankkiserver/api/favorite/controller/request/FavoritePostRequest.java

+    @NotBlank(message = "제목이 비었습니다.")
+    @Size(max = 20, message = "제목 길이가 20 이상입니다.")
+    String title,
+    List<String> details


@SiZe 추가해서 최대 리스트 요소수 추가하는 것은 어떨까요?

일단 @SiZe가 List size에도 적용되는지 Test 해보고 된다면 요구사항대로 1이상 2이하로 바꾸겠습니다 그리고 제목 길이는 18자 이하로 변경되어서 그것도 반영하겠습니다!

Parkjyun · 2024-07-11T10:28:28Z

src/main/java/org/hankki/hankkiserver/domain/favorite/repository/FavoriteRepository.java

+  @Query("delete from Favorite f where f in :favorites")
+  void deleteAll(@Param("favorites") List<Favorite> favorites);
+
+  @Query("select f from Favorite f join fetch f.user where f.id in :favoriteId")


favorites.members의 각각의 멤버의 id를 갖고오기 위해 fetchjoin을 하고 계신 거 같은데 pk같은 경우는 지연로딩만으로도 조회를 할 수 있는 것으로 알고 있습니다. 한번 확인해주시겠어요?
그리고 fetch join쓰시는 경우에는 함수명에 명시적으로 적어주세요

Parkjyun · 2024-07-11T12:40:35Z

src/main/java/org/hankki/hankkiserver/api/favorite/service/FavoriteFinder.java

+
+  public List<Favorite> findByIds(final List<Long> ids) {
+    return favoriteRepository.findByIds(ids);
+  }


사소하지만 복수의 값을 반환한다면 findAllbyIds로 명명하는 것은 어떨까요?

Parkjyun · 2024-07-11T12:43:43Z

src/main/java/org/hankki/hankkiserver/api/favorite/service/FavoriteCommandService.java

+    Long userId = command.userId();
+    favorites.forEach(favorite -> {
+      if (!favorite.getUser().getId().equals(userId)) {
+        throw new UnauthorizedException(UserErrorCode.USER_FORBIDDEN);
+      }
+    });


마찬가지로 userId한번만 쓰인다면 변수로 뽑지 않아도 될 것 같습니다.

Parkjyun · 2024-07-11T12:44:22Z

src/main/java/org/hankki/hankkiserver/api/favorite/service/FavoriteDeleter.java

+
+  private final FavoriteRepository favoriteRepository;
+  public void deleteAll(List<Favorite> favorites) {
+


공백 맞춰주세요

PicturePark1101 added the feature label Jul 8, 2024

PicturePark1101 requested review from kgy1008 and Parkjyun July 8, 2024 08:56

PicturePark1101 self-assigned this Jul 8, 2024

kgy1008 reviewed Jul 8, 2024

View reviewed changes

PicturePark1101 force-pushed the feat/16 branch 3 times, most recently from 376805d to 7c8a47e Compare July 11, 2024 04:27

Parkjyun requested changes Jul 11, 2024

View reviewed changes

PicturePark1101 added 20 commits July 11, 2024 22:04

[feat] add create static method and remove unnecessary filed

c5a6503

[feat] create FavoriteCommandService (before add login logic)

e7549bf

[feat] create request, command dto

9373042

[fix] change FavoriteController file name

743dd91

[refactor] change dto name

22bbe3b

[refactor] change code style

d4ab713

[refactor] change code style

4eaf063

[refactor] change code style in commandservice

a19a7c8

[refactor] refactor createFavorite return format

40b0c2d

[feat] create findById in FavoriteAdpater

371d495

[refactor] change package structure

3439ded

[fix] fix import error occurring after a rebase

45dbac4

[feat] add login

6c61d84

[refactor] reflecting review

74c14cf

[feat] implementation multi delete

ecf2c5a

[refactor] change name finder

7b1e057

[feat] add exception

200bf00

[feat] add batch FavoriteStore

a98f15f

[feat] add FavoriteStoreDeleter

30ea548

[feat] add Favorite @onetomany

766126a

PicturePark1101 added 13 commits July 11, 2024 22:04

[feat] feat delete FavoriteStore

98460dc

[feat] create ErrorCode

c9b5c08

[feat] add delete query

147b3cc

[feat] add Favorite Deleter, Finder and FavoriteStore Deleter

af95019

[refactor] refactor response, request dto

c838a7a

[feat] add delete and set response

9484aac

[feat] add ErrorCode

5cb42dc

[refactor] refactor with UnauthorizedException

5b557c4

[refactor] Change to in query

035ce09

[feat] add Column

702a5f5

[feat] add image

7ee6a4a

[refactor] remove fetch join

4200074

[refactor] apply code review

1e87ceb

PicturePark1101 force-pushed the feat/16 branch from d74f802 to 1e87ceb Compare July 11, 2024 13:53

Parkjyun merged commit 71d52d2 into develop Jul 11, 2024
1 check passed

PicturePark1101 deleted the feat/16 branch July 12, 2024 08:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] 족보 생성 삭제 API #23

[feat] 족보 생성 삭제 API #23

PicturePark1101 commented Jul 8, 2024 •

edited

Loading

kgy1008 left a comment

kgy1008 Jul 8, 2024

PicturePark1101 Jul 9, 2024

kgy1008 Jul 8, 2024

kgy1008 Jul 8, 2024

PicturePark1101 Jul 9, 2024

kgy1008 Jul 8, 2024

Parkjyun Jul 11, 2024

kgy1008 Jul 8, 2024

Parkjyun left a comment

Parkjyun Jul 11, 2024

PicturePark1101 Jul 11, 2024

Parkjyun Jul 11, 2024

Parkjyun Jul 11, 2024

Parkjyun Jul 11, 2024

PicturePark1101 Jul 11, 2024

Parkjyun Jul 11, 2024

Parkjyun Jul 11, 2024

PicturePark1101 Jul 11, 2024 •

edited

Loading

Parkjyun Jul 11, 2024

Parkjyun Jul 11, 2024

Parkjyun Jul 11, 2024

Parkjyun Jul 11, 2024


		private final FavoriteRepository favoriteRepository;

		public Favorite findById(final long id) {


		private final FavoriteRepository favoriteRepository;
		public void deleteAll(List<Favorite> favorites) {

[feat] 족보 생성 삭제 API #23

[feat] 족보 생성 삭제 API #23

Conversation

PicturePark1101 commented Jul 8, 2024 • edited Loading

Related Issue 📌

Description ✔️

To Reviewers

족보 생성 응답값

족보 생성 쿼리

(에러) 족보 title 길이 20 이상 or 빈 문자열

족보 삭제 쿼리실행 Test

kgy1008 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Parkjyun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PicturePark1101 Jul 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PicturePark1101 commented Jul 8, 2024 •

edited

Loading

PicturePark1101 Jul 11, 2024 •

edited

Loading