[feat] 조회수 조희 API #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public class ReportService { | ||
|
|
||
| private final ReportFinder reportFinder; | ||
|
|
There was a problem hiding this comment.
@Trancation(readOnly=true) 처리해주세요
Parkjyun
requested changes
Jul 10, 2024
Comment on lines
22
to
23
| ReportServiceResponse response = new ReportServiceResponse(reportService.getMyReportSequence()); | ||
| return HankkiResponse.success(CommonSuccessCode.OK, response); |
| private final ReportFinder reportFinder; | ||
|
|
||
| public long getMyReportSequence() { | ||
| return reportFinder.getReportCount() + 1; |
There was a problem hiding this comment.
1은 이름에 의미를 담아 상수로 빼주세요
@transactional(readOnly=true)붙여주세요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #30
Description ✔️
To Reviewers
딱히 예외가 발생할만한 상황이 없는 것 같아 예외처리는 하지 않았습니다.