[refac] BaseResponse, ExceptionHandler 수정 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgy1008
reviewed
Jul 9, 2024
| response.setContentType(MediaType.APPLICATION_JSON_VALUE); | ||
| response.setCharacterEncoding("utf-8"); | ||
| response.setStatus(httpStatus.value()); | ||
| PrintWriter writer = response.getWriter(); | ||
| writer.write(objectMapper.writeValueAsString(BaseResponse.of(errorCode))); | ||
| writer.write(objectMapper.writeValueAsString(HankkiResponse.fail(authErrorCode))); |
| response.setContentType(MediaType.APPLICATION_JSON_VALUE); | ||
| response.setCharacterEncoding("utf-8"); | ||
| response.setStatus(httpStatus.value()); | ||
| PrintWriter writer = response.getWriter(); | ||
| writer.write(objectMapper.writeValueAsString(BaseResponse.of(errorCode))); | ||
| writer.write(objectMapper.writeValueAsString(HankkiResponse.fail(authErrorCode))); |
|
|
||
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum UserErrorCode implements ErrorCode { |
There was a problem hiding this comment.
에러 상황별로 errorCode 클래스 나눠서 관리하는거 너무 좋습니당
| @RequiredArgsConstructor(access = AccessLevel.PRIVATE) | ||
| public class HankkiResponse<T> { | ||
|
|
||
| private final int status; |
There was a problem hiding this comment.
P1
저희 혹시 status는 code로 주기로 하지 않았나요??
| @@ -52,6 +52,6 @@ private String getToken(final String refreshToken) { | |||
| if (refreshToken.startsWith(BEARER)) { | |||
| return refreshToken.substring(BEARER.length()); | |||
| } | |||
| throw new UnauthorizedException(ErrorCode.INVALID_ACCESS_TOKEN); | |||
| throw new UnauthorizedException(AuthErrorCode.INVALID_ACCESS_TOKEN); | |||
There was a problem hiding this comment.
P1
리프래시 토큰 검증 과정이라 INVALID_ACCESS_TOKEN은 적절하지 않은 것 같습다
PicturePark1101
approved these changes
Jul 9, 2024
kgy1008
pushed a commit
that referenced
this pull request
Jul 10, 2024
* [refac] create interface for code * [refac] refactor exception and common api response * [feat] create response advice * [refac] fix typo in UserErrorCode.java * [refac] change Hankki response creation logic * [refac] delete duplicated BaseTimeEntity.java * [refac] fix HankkiResponse.java as api spec * [refac] fix unappropriate error message while validating refreshtoken * [refac] change typo in ResponseAdvice.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #8
Description ✔️
To Reviewers
전체적인 구조 코드리뷰 부탁드립니다.