[fix] 소셜 로그인 오류 수정 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
고생하셨습니당 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #44
Description ✔️
accessToken claims에 role 추가해서 role 존재 여부로 refreshToken과 accessToken을 구분하였습니다.
filter chain을 bean으로 등록하지 않았기에 WhiteList에 등록된 url은 필터를 거치지 않음 -> 때문에 reissue api의 경우 white list에 등록을 해두었기 때문에 따로 filter에서 refreshToken으로 요청이 들어왔을 때 해당 request api가 reissue api인지 검증하는 로직은 제외하였습니다. 즉, refresh Token으로 들어오는 모든 요청에 대해서 예외를 던졌습니다.
또한 비밀키를 인코딩하는 로직에 오류가 있어서 이 또한 수정했습니다.
(이 과정에서 yml 파일이 조금 바뀌었습니다. submodule update 해주세요)
To Reviewers
yml 파일 업데이트 되었습니다.