Workaround for Skycrate deletion #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments out not-working function to create a gravity block at entity location and instead opts to drop crate as an item.
Avalon2106
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Comments out the physical skycrate box entity from existing off the lines (entity physics suck to do, so I totally get it lol)
Changed item drop to happen at the position of skycrate box.
Changes match what was shown in the PR, making it as approved and ready for merge
Pabilo8
merged commit 3b9b474
into
Team-Immersive-Intelligence:dev/avalon/main
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments out not-working function to create a gravity block at entity location and instead drops crate as an item. Couldn't get the block drop method to work. There was a typo which I fixed, however, the falling crate block disappears when it hits the ground.
In addition to using the item drop method, the position is changed to be beneath the Skycrate post. If you want, you can modify line 120 to instead be -1; this would put it inside the Skycrate post collision when created, which you can pretend it is a sort of "explosion".
Resolves #367
Showcase:
Desktop 2024.10.23 - 19.37.33.01.webm