Use preallocated buffer in add_random_field #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tkoskela
commented
May 19, 2020
tkoskela
commented
- Removed double implementation of add_random_field
- renamed dx_buffer and dy_buffer to field_buffer_1, field_buffer_2 respectively
- fixed dx_buffer getting passed twice to tsunami_update
- Removed double implementation of add_random_field - renamed dx_buffer and dy_buffer to field_buffer_1, field_buffer_2 respectively - fixed dx_buffer getting passed twice to tsunami_update
giordano
reviewed
May 19, 2020
Use a buffer array to generate the random numbers in gaussian field
giordano
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.