Feature/#52 mypage followlist #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
large, medium button component 추가
MVI Pattern 적용
cacaocoffee
requested changes
Jul 10, 2024
Comment on lines
+38
to
+44
| fun getButtonAndTextColor(isFollowed: Boolean): Pair<Color, Color> { | ||
| return if (isFollowed) { | ||
| Pair(RecordyTheme.colors.gray08, RecordyTheme.colors.white) | ||
| } else { | ||
| Pair(RecordyTheme.colors.white, RecordyTheme.colors.gray08) | ||
| } | ||
| } |
There was a problem hiding this comment.
텍스트와 버튼의 컬러를 하나로 Pair 를 활용해서 받는건 생각 못해봤는데 잘 살펴보고 가요
| import androidx.compose.ui.unit.dp | ||
| import com.record.designsystem.theme.RecordyTheme | ||
|
|
||
| @Composable | ||
| fun RecordyButton( | ||
| fun RecordyButtonLarge( |
There was a problem hiding this comment.
이름 변경으로 인해 conflict가 난거 같아요 rebase를 통해 하나로 통일하셔야할 거 같아요
이미 develop 에 올라온 버튼의 경우 다른 분들이 사용하고 계실 수 있으니 수정을 피하는게 좋다고 생각이 드네요
lsakee
reviewed
Jul 11, 2024
| colors = ButtonDefaults.buttonColors( | ||
| containerColor = colors.first, | ||
| ), | ||
| shape = RoundedCornerShape(8.dp), |
There was a problem hiding this comment.
요러한 부분들 staless하게 호이스팅해도 좋을 것 같습니다
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Button( | ||
| onClick = onClick, |
There was a problem hiding this comment.
CustomClickable만들어 놓은 거 사용해서 리플같은 것도 고료하면 더욱 좋을거 같습니다.
cacaocoffee
approved these changes
Jul 11, 2024
using derivedState
large, medium button component 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
SideEffect로 상태 전달합니다🌱 PR 포인트
📸 스크린샷
2024-07-11.025216.mp4
📮 관련 이슈