Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] #59 design component #67

Merged
merged 3 commits into from
Jul 11, 2024
Merged

[Refactor] #59 design component #67

merged 3 commits into from
Jul 11, 2024

Conversation

lsakee
Copy link
Contributor

@lsakee lsakee commented Jul 11, 2024 •
edited
Loading

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ๋ฒ„ํŠผ,๋‹ค์ด์–ผ๋กœ๊ทธ ๋“ฑ ์ปดํฌ๋„ŒํŠธ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
    ๐ŸŒฑ PR ํฌ์ธํŠธ
  • ๋ฐ”๋€ ๋ถ€๋ถ„ ํ”„๋ฆฌ๋ทฐ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@cacaocoffee cacaocoffee changed the title refactor component [Refactor] #59 component Jul 11, 2024
@cacaocoffee cacaocoffee changed the title [Refactor] #59 component [Refactor] #59 design component Jul 11, 2024
sebbbin
sebbbin approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@sebbbin sebbbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค ^^ ์•„์ฃผ ์ข‹์€ ์ฝ”๋“œ์ž…๋‹ˆ๋‹ค ~ ํ•˜ํ•˜
(์•ˆ๋“œ์—๊ฒŒ ์ƒท์•„์›ƒ์„ ๋ฐ›๋‹ค ๐Ÿ… )

seohee0925
seohee0925 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@seohee0925 seohee0925 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ธฐ๊น”๋‚˜๋Š” ์ฝ”๋“œ๋„ค์š”
๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹น

seohee0925
seohee0925 approved these changes Jul 11, 2024
View reviewed changes
core/designsystem/src/main/java/com/record/designsystem/component/button/BasicButton.kt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ˜น์‹œ BasicButton์ด๋ž‘ RecordyButton์„ ๋ถ„๋ฆฌํ•œ ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ปค์Šคํ…€์œผ๋กœ ๋ฒ„ํŠผ ์‚ฌ์šฉํ•˜๋ ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค

@lsakee lsakee force-pushed the feature/#59-refactor-component branch from f26c1ae to 166babb Compare July 11, 2024 18:59
Sangwook123
Sangwook123 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sangwook123 Sangwook123 merged commit ff85f12 into develop Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebbbin sebbbin sebbbin approved these changes

@seohee0925 seohee0925 seohee0925 approved these changes

@Sangwook123 Sangwook123 Sangwook123 approved these changes

Assignees

@lsakee lsakee

Labels
๊ธฐ์ดˆ์„ธํŒ…ํŒ…ํŒ…ํƒฑํƒฑํƒฑํ›„๋ผ์ดํŒฌ๋†€์ด ์‚ญ ๐ŸงŸ๐Ÿฝ ์‡ฝ์‡ฝ์‡ฝ ์‚ญ์พก์ด ์‚ญ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

design: design component
5 participants
@lsakee @sebbbin @seohee0925 @Sangwook123 @cacaocoffee