Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] theme v1 기능 리팩토링 #291

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

thguss
Copy link
Member

@thguss thguss commented Jun 21, 2024

✨ Related Issue

📝 기능 구현 명세

  • 테스트 코드 대체

🐥 추가적인 언급 사항

  • 서비스 계층에서 DTO를 VO로 대체했습니다.
  • 필요없는 DTO 클래스를 삭제했습니다.
  • 컨트롤러에서 사용하는 메서드 이름을 유저 액션에 적절한 이름으로 변경했습니다.
  • ImageInfo 이름을 사용하는 칼럼/필드를 ImageLinks로 변경했습니다. Info는 Information의 축약어로, Java에 어울리지 않는다고 판단하였으며, Image의 Link를 모아두는 클래스라는 점에서 ImageLinks 이름을 채택했습니다.

@thguss thguss self-assigned this Jun 21, 2024
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@thguss thguss requested a review from Chan531 June 21, 2024 11:07
@Chan531
Copy link
Contributor

Chan531 commented Jun 21, 2024

ImageLink VO로 묶어서 깔끔하군요!
확인했습니다!

@thguss thguss merged commit 40d7c09 into develop Jun 21, 2024
1 check passed
@thguss thguss deleted the refactor/#290-v1-theme-api branch June 21, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] theme v1 api 관련 ThemeType 칼럼 반영
2 participants