Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 도전 루틴 목록 조회 #302

Merged
merged 14 commits into from
Jun 28, 2024
Merged

Conversation

Chan531
Copy link
Contributor

@Chan531 Chan531 commented Jun 27, 2024

✨ Related Issue

📝 기능 구현 명세

image

  • 도전 루틴 조회 api
    image
  • 도전 루틴 조회 테스트

🐥 추가적인 언급 사항

  • 계속해서 리뷰해주신 VO 활용, dto를 좀 더 깔끔하게 작성해보고자 노력했습니다!
  • 소현님이 이전에 작성해주신 코드 참고해서 더 원활하게 짤 수 있었습니다.

@Chan531 Chan531 added chan 찬 작업 feat 기능 개발 test 테스트 labels Jun 27, 2024
@Chan531 Chan531 requested a review from thguss June 27, 2024 12:56
@Chan531 Chan531 self-assigned this Jun 27, 2024
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전날 정신없는 상태에서 리뷰를 남겨 추가적으로 더 남깁니다!

@Chan531 Chan531 merged commit 4cf8a18 into develop Jun 28, 2024
2 checks passed
@Chan531 Chan531 deleted the feat/#284-challenge-routine branch July 5, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chan 찬 작업 feat 기능 개발 test 테스트
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 도전 루틴 목록 조회
2 participants