[FEAT] 회원 별 데일리 루틴 리스트 조회 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csb9427
approved these changes
Jan 11, 2024
| } | ||
|
|
||
| private Member findMember(Long id) { | ||
| return memberRepository.findById(id) |
There was a problem hiding this comment.
별거 아니긴 한데 유저가 없을 때는 NULL 값이 들어오는데 에러 처리가 따로 필요할까요?
There was a problem hiding this comment.
@csb9427
기본적으로 JPA에서 제공하는 findById 메소드는 Optional 타입을 반환해요. Member 값이 없을 때는 빈 Optional 값을 보내게 됩니다. 해당 값에 대해 아래의 .orElseThrow(() -> new EntityNotFoundException(INVALID_MEMBER.getMeesage())); 코드로 이러한 경우를 처리하게 됩니다!
아래 Optional 관련 레퍼런스 추가해두겠습니다 :)
https://mangkyu.tistory.com/70
Chan531
approved these changes
Jan 11, 2024
| @@ -90,4 +86,16 @@ private void checkRoutineForMember(Member member, MemberDailyRoutine routine) { | |||
| throw new IllegalStateException(INACCESSIBLE_ROUTINE.getMeesage()); | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항