[Hotfix/#103] in app error, like.. etc #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohyun127
added
๐จย [FIX]
sohyun127
requested review from
a team,
Eonji-sw and
chanubc
and removed request for
a team
chanubc
approved these changes
Nov 11, 2024
Comment on lines
+128
to
+145
| fun Context.showAlertDialog( | ||
| title: String, | ||
| message: String, | ||
| positiveButtonText: String, | ||
| negativeButtonText: String, | ||
| onPositiveClick: () -> Unit, | ||
| ) { | ||
| val builder = AlertDialog.Builder(this) | ||
| builder.setTitle(title) | ||
| .setMessage(message) | ||
| .setPositiveButton(positiveButtonText) { dialog, _ -> | ||
| dialog.dismiss() | ||
| onPositiveClick() | ||
| } | ||
| .setNegativeButton(negativeButtonText) { dialog, _ -> dialog.dismiss() } | ||
|
|
||
| builder.create().show() | ||
| } |
There was a problem hiding this comment.
์ปดํฌ๋ํธ ๋ถ๋ฆฌ ์ข๋ค์ ๐
| @@ -21,7 +21,7 @@ class SingleEventHandler private constructor() { | |||
| } | |||
|
|
|||
| companion object { | |||
| private const val DEBOUNCE_DELAY = 500L | |||
| private const val DEBOUNCE_DELAY = 200L | |||
There was a problem hiding this comment.
debounce๊ฐ ๋ฌธ์ ๋ฉด throttle๋ก ๋ฐ๊พธ์ด๋ณด๋๊ฑด ์ด๋ค๊ฐ์??
There was a problem hiding this comment.
์ธ๋ผ์ด ํด๋ณผ๊ฒ์ฅ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
โ ๐๐ต๐ฒ๐ฐ๐ธ-๐๐ถ๐๐
๐ ๐๐๐๐๐ฒ๐
๐๐ช๐ผ๐ฟ๐ธ ๐๐ฒ๐๐ฐ๐ฟ๐ถ๐ฝ๐๐ถ๐ผ๐ป
๐ท ๐ฆ๐ฐ๐ฟ๐ฒ๐ฒ๐ป๐๐ต๐ผ๐
in app update
KakaoTalk_20241109_182346017.mp4
๐ฌ ๐ง๐ผ ๐ฅ๐ฒ๐๐ถ๐ฒ๐๐ฒ๐ฟ๐
์ข์์ ๋๋ฅด๊ณ ๋ฐ๋ก ํ ์์ธ๋ก ์ด๋ํ ๊ฒฝ์ฐ ๊ฐ๋ ์ข์์ api ์๋ต์ด ์ค๊ธฐ ์ ์, ์์ธ api ์๋ต์ด ๋จผ์ ์์
๋ฐ์์ด ์๋์ด ์๋ ์ค๋ฅ๊ฐ ์์ต๋๋ค => ๊ธฐ์กด์ ๋ฐ์ํ๋ ๋ฌธ์
๋๋ฐ์ด์ค ๋๋ ์ด๋ฅผ ์ค์ด๊ธด ํด์ ๋ฌธ์ ๋ฐ์์ด ๋น๋๊ฐ ๋ ํ๊ธดํฉ๋๋ค. ์๋ต ์ค๊ธฐ ์ ์ ์์ state ๋ก์ปฌ์์ ๋ฐ์ํ๋ ๋ฐฉ๋ฒ .. ๋ฑ ๊ณ ๋ฏผ์ ์กฐ๊ธ ๋ ํด๋ณด๊ณ ๊ณ ์ณ๋ณผ๊ฒ์ฅ