Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#107 fix posting UI #109

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Feature/#107 fix posting UI #109

merged 2 commits into from
Nov 21, 2024

Conversation

Eonji-sw
Copy link
Member

@Eonji-sw Eonji-sw commented Nov 21, 2024 •
edited
Loading

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • placeholder ์ˆ˜์ •
  • ๋ณธ๋ฌธ ์ด๋ชจํ‹ฐ์ฝ˜ ์ž…๋ ฅ ๊ฐ€๋Šฅํ•˜๊ฒŒ ์ˆ˜์ •

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

2024-11-21.9.34.28.mov

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

๋งค์šฐ ๊ท€์—ฌ์šด PR

@Eonji-sw Eonji-sw added ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ ๐Ÿ’Ÿย [UI] UI ์ž‘์—… xml ํŒŒ์ผ ๊ฑด๋“ค๋ฉด ์š”๊ฑฐ ๐Ÿฐ ์–ธ์ง€ ๊ธฐ๋งŒ์ง€ labels Nov 21, 2024
@Eonji-sw Eonji-sw self-assigned this Nov 21, 2024
sohyun127
sohyun127 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@sohyun127 sohyun127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTTTM ๊ท€์š”๋ฏธ PR

@Eonji-sw Eonji-sw merged commit 3d8c6e3 into develop Nov 21, 2024
1 check passed
@Eonji-sw Eonji-sw deleted the feature/#107-fix-posting-ui branch November 21, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohyun127 sohyun127 sohyun127 approved these changes

Assignees

@Eonji-sw Eonji-sw

Labels
๐Ÿฐ ์–ธ์ง€ ๊ธฐ๋งŒ์ง€ ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ ๐Ÿ’Ÿย [UI] UI ์ž‘์—… xml ํŒŒ์ผ ๊ฑด๋“ค๋ฉด ์š”๊ฑฐ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] : posting UI ์ˆ˜์ •
2 participants
@Eonji-sw @sohyun127