New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IconicButtons init #81

Open

fzzyhmstrs wants to merge 1 commit into TeamMidnightDust:main from fzzyhmstrs:main

fzzyhmstrs commented Sep 21, 2024 •

edited

Loading

Fixes #80

removes the init method call that is leaking this from iconic$onInitButton

init is called in the render method anyways, as pointed out by Gaming32. This more lazy initialization is good practice in any case.


          Remove IconicButtons init

27be58d

removes the init method call that is leaking `this` from iconic$onInitButton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet