Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: seperate university, major post list #405

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: seperate university, major post list #405

wants to merge 5 commits into from

Conversation

seoljiwon
Copy link
Contributor

  • 원래 의도는 server side 코드가 완전히 같으니, query로 majorId를 받아 어떤 상황이든 한 번에 구할 수 있도록 하자!
  • 였는데 당시에 짜면서도 고민이 많았어요 결론적으로는 전체 학교 조회랑 세부 major조회는 나누는 게 좋을 것 같아서 바꿨습니다!

@seoljiwon seoljiwon added the fix Something isn't working label Jan 9, 2023
@seoljiwon seoljiwon self-assigned this Jan 9, 2023
@seoljiwon seoljiwon force-pushed the feature/seperate-university-major branch from ebe94b8 to eb0354c Compare January 9, 2023 05:07
@seoljiwon seoljiwon force-pushed the feature/seperate-university-major branch from eb0354c to 4f172ed Compare January 9, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wngus4296 wngus4296 Awaiting requested review from wngus4296

@eunji8784 eunji8784 Awaiting requested review from eunji8784

At least 1 approving review is required to merge this pull request.

Assignees

@seoljiwon seoljiwon

Labels
fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seoljiwon