Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose theme improvements #11539

Open
wants to merge 3 commits into
base: refactor
Choose a base branch
from

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Implement black theme in Compose.
  • Update the Compose theme colors with ones generated using the Material Theme Builder. This new theme follows the Material 3 guidelines.
  • Update the background colors in the existing app theme to match the Compose theme.

Before/After Screenshots/Screen Record

  • Before:

    Screenshot_20240916_154150_NewPipe refactor
    Light theme

    Screenshot_20240916_154127_NewPipe refactor
    Dark theme

  • After:

    Screenshot_20240916_154705_NewPipe Compose-theme-improvements
    Light theme

    Screenshot_20240916_154725_NewPipe Compose-theme-improvements
    Dark theme

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/large PRs with less than 750 changed lines label Sep 16, 2024
Copy link

sonarcloud bot commented Sep 16, 2024

@AudricV AudricV added the GUI Issue is related to the graphical user interface label Sep 16, 2024
@ShareASmile ShareASmile added the rewrite Issues and PRs related to rewrite label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issue is related to the graphical user interface rewrite Issues and PRs related to rewrite size/large PRs with less than 750 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants