DRAW-375 synchronized -> Redis Lettuce 분산 락 리팩터링 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/kotlin/com/xorker/draw/mafia/MafiaGameService.kt # core/src/main/kotlin/com/xorker/draw/mafia/phase/MafiaPhaseService.kt
comforest
reviewed
Oct 7, 2024
| private fun getLock(key: String): Boolean { | ||
| return redisTemplate | ||
| .opsForValue() | ||
| .setIfAbsent(key + LOCK, LOCK, Duration.ofSeconds(1)) ?: throw NotFoundLockKeyException |
Comment on lines
+4
to
+5
| fun lock(key: String) | ||
| fun unlock(key: String) |
There was a problem hiding this comment.
Suggested change
| fun lock(key: String) | |
| fun unlock(key: String) | |
| fun lock(key: String, call: ()-> Unit) |
p3. lock / unlock 구분하지 말고,
lock 에서 람다를 받아서 해당 액션 끝나면 해제 해주는건 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)