Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmoniqa – The soundtrack to your mood #280

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

HeleneWestrin
Copy link

Netlify link

Harmoniqa »

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice idea for a chatbot 🎵 Let's have a look at some feedback 👇

HTML/CSS

  • Not much to say here, you kept it clean and structured 👍
  • Nice use of CSS variables for colors (:root) to maintain a consistent theme and simplify future changes.

JavaScript

  • Great use of constants for managing delays and selectors, making the code more maintainable and adjustable.
  • Helper functions like getLatestMessage(), showMessage(), userMessage(), and botMessage() are well-defined
  • The file is quite big which makes it a little bit difficult to overview. However, your comments help a lot and when we move over to React you will be able to make your code even more modular (splitting up components into different files).
  • Nice usage of switch!

Keep up the good work 🥳


document.getElementById("button-moody").addEventListener("click", () => {
colorSelection("Moody");
inputWrapper.innerHTML = ""; // Remove the input area after user replies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants